Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more conscious with version number #2028

Closed
schtefan opened this issue Jun 12, 2023 · 1 comment · Fixed by #2059
Closed

Be more conscious with version number #2028

schtefan opened this issue Jun 12, 2023 · 1 comment · Fixed by #2059
Labels
feature request New feature or request

Comments

@schtefan
Copy link

I get notification about new releases of jfrog-cli. When there is an update of the minor version number, I usually look into the change log what has changed. Often I then see that there are only bug fixes listed.
Please be more conscious with the version number: when adopting the semantic versioning scheme,, implementing only bug fixes means to only increase the patch version. Increasing the minor version implies to provide improvements or new features with API compatibility to the previous version.
Thanks!

@schtefan schtefan added the feature request New feature or request label Jun 12, 2023
@yahavi yahavi linked a pull request Jul 4, 2023 that will close this issue
4 tasks
@yahavi
Copy link
Member

yahavi commented Jul 4, 2023

@schtefan
Thank you for using the JFrog CLI.
The JFrog CLI relies on several components, including jfrog-cli-core, jfrog-client-go, build-info-go, and others.

In order to streamline the release process, we have implemented automated release notes generation. Here is how it works:

  1. When a developer adds a new feature to jfrog-cli-core.
  2. We release a minor version of jfrog-cli-core.
  3. We release a minor version of jfrog-cli, with the new the version of jfrog-cli-core. In this particular scenario, it also introduces a new feature to the jfrog-cli.
  4. The release notes generator automatically sends an email with the release notes, but it does not include the changes made to jfrog-cli-core.
  5. We manually edit the release notes to include the changes made to jfrog-cli-core.

To ensure that the release email always contains accurate information, we have created a pull request at #2059.
To ensure that the release notes sent by email include the relevant information for all components, a human will be responsible for generating the release notes in the upcoming release.

If you have any further questions, please don't hesitate to ask.

@yahavi yahavi closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants