Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Either Bool Link instead of Maybe Link in NodeInfo #6

Open
digitalheir opened this issue Feb 17, 2015 · 3 comments
Open

Use Either Bool Link instead of Maybe Link in NodeInfo #6

digitalheir opened this issue Feb 17, 2015 · 3 comments

Comments

@digitalheir
Copy link

Either Bool Link instead of Maybe Link in NodeInfo's link field, so we can denote whether a leaf node is 'accepting' of node identifications. Original hypothesis and conclusion node are 'closed' (False), while all other leaf nodes are 'open' (True).

I volunteer to make this edit.
@jgonggrijp
Copy link
Owner

You mean Either Bool Link, right? ;-)

@digitalheir digitalheir changed the title Use Bool Link instead of Maybe Link in NodeInfo Use Either Bool Link instead of Maybe Link in NodeInfo Feb 18, 2015
@digitalheir
Copy link
Author

Uhhh, yeah. I'm working on feature branch for it right now; need to adapt a bunch of code that still depends on Maybe Link.

digitalheir added a commit to digitalheir/net-prove that referenced this issue Mar 19, 2015
@digitalheir
[jgonggrijp#6] Added NodeLink type that uses Either Bool Link ins…
390fe35 
…tead of `Maybe Link`
@digitalheir
Copy link
Author

Please see branch feature-bool-link-type. We need a Unifiable instance for the new type NodeLink.

I don't really understand the Unifiable code, so I'm afraid to touch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digitalheir @jgonggrijp