Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes "save" doesn't work #1857

Open
2 tasks done
danfloyd111 opened this issue Sep 3, 2024 · 9 comments
Open
2 tasks done

Sometimes "save" doesn't work #1857

danfloyd111 opened this issue Sep 3, 2024 · 9 comments
Labels
issue template not filled Issue template not filled in, ignoring unless filled

Comments

@danfloyd111
Copy link

danfloyd111 commented Sep 3, 2024

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Auto-save and manual save through the menu are inconsistent, sometimes they work and sometimes no. The shortcut "cmd+s" always fails without error messages.

To Reproduce
Steps to reproduce the behavior:

  1. Do some modifications to an existing schema
  2. Click on 'save' or wait for / trigger the auto-save
  3. Wait for the message "All changes saved" to appear in the menu bar
  4. Quit the application
  5. Open the application again
  6. The modifications are gone like nothing happened

Expected behavior
The modifications should be saved, if not possible for some reason an error message should be shown.

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io DESKTOP version 24.7.8

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.6.1
  • Browser Safari
  • Browser Version 17.6

Additional context
I'm using exclusively the desktop client, I did not test this functionality on the browser. I switched all the available "themes" but the issue persists. I added the details about my main browser (but I've also other browser installed on my machine).

@alderg
Copy link
Contributor

alderg commented Sep 3, 2024

Where did you save the file?

@danfloyd111
Copy link
Author

Where did you save the file?

In a local folder under my home directory

@alderg
Copy link
Contributor

alderg commented Sep 3, 2024

Is that directory synched with a cloud storage such as Google Drive, OneDrive or Dropbox?

@danfloyd111
Copy link
Author

danfloyd111 commented Sep 3, 2024

Is that directory synched with a cloud storage such as Google Drive, OneDrive or Dropbox?

No, it's completely local, no iCloud either. Other than draw.io files, it contains a '.git' file to sync it with a remote repository, but I'm not performing any git ops in between.

I created a new diagram outside that folder, still completely local and without binding this to any git repository: the issue is still here. The auto-save seems more consistent, it works 80% of the times. Saving with cmd+s is not working at all (no messages are shown) while saving through the menu triggers the "all changes are saved" messages but after quitting the application the modifications disappear.

@alderg
Copy link
Contributor

alderg commented Sep 3, 2024

Are you using the desktop version or the web app (in a browser)? Please include all the version information requested in the original issue template.

@davidjgraph davidjgraph added the issue template not filled Issue template not filled in, ignoring unless filled label Sep 3, 2024
@danfloyd111
Copy link
Author

Are you using the desktop version or the web app (in a browser)? Please include all the version information requested in the original issue template.

Sorry, I thought I did that by leaving blank the "browser lines". Fixing it now.
I'm using the desktop version 24.7.8.

@davidjgraph davidjgraph transferred this issue from jgraph/drawio Sep 3, 2024
@danfloyd111
Copy link
Author

Edit: I was confused reading "If you delete part/all or miss parts out your issue will be closed." in the instruction, this is the reason why I left some fields not filled.
Following the example of other reports, I cleaned the report. Please let me know if now it is ok.

@alderg
Copy link
Contributor

alderg commented Sep 3, 2024

Yes, all good. But it will be difficult to provide any help since you seem to be the only person to have this issue. We'd need more information to help us narrow down the problem. For example, what is the size of the file you are trying to save?

@danfloyd111
Copy link
Author

Yes, all good. But it will be difficult to provide any help since you seem to be the only person to have this issue. We'd need more information to help us narrow down the problem. For example, what is the size of the file you are trying to save?

The file I'm working on is about 30MB, but I was able to reproduce the issue on a new schema created just for testing purposes which is about 4KB.

I can record a video of the issue if it can be helpful.
Thanks for your super quick replies!

More info: it doesn't seems to be a "I'm too quick to quit issue". This time I created a test file with a text field and triggered the auto-save feature, then I closed the schema. I opened the schema again and did a quick modification of the text field, then I saved the file through the menu [screenshot 1], then after the "all changes saved" badge appeared on the top I quit the application (cmd+q). After I re-opened the application, the modification I did moments before was gone [screenshot 2]. Hitting cmd+s doesn't even trigger the "all changes saved" badge.

Screenshot 1
Screenshot 2024-09-03 at 16 34 20

Screenshot 2
Screenshot 2024-09-03 at 16 34 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue template not filled Issue template not filled in, ignoring unless filled
Projects
None yet
Development

No branches or pull requests

3 participants