Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add a social media sharing button to every post #26

Closed
Ravenbird opened this issue Nov 11, 2020 · 8 comments
Closed

Proposal: Add a social media sharing button to every post #26

Ravenbird opened this issue Nov 11, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@Ravenbird
Copy link

With Diaspora's web interface it is easy to copy the address of a post to share it. Unfortunately, this is not possible with Inspiration. Therefore it would be good to have a button to pass it on to other media and to copy the address.

@jhass jhass added the enhancement New feature or request label Nov 11, 2020
@jhass
Copy link
Owner

jhass commented Nov 11, 2020

So the "right way" to do this would be for the API to return something like a share_url property for the post, which it currently doesn't. So right now the client could only do this by making assumptions about what the URL should be.

@Ravenbird
Copy link
Author

Ravenbird commented Nov 11, 2020

Yeah you are right. If not, the question is whether the API works with the normal Post-IDs on the respective post. If this is the case, you can use it to create a suitable URL. For example, if you have the Post-ID 8869742 for an account on nerdpol.ch, this is what you get:

https://nerdpol.ch/posts/8869742

But if the API works with something completely different it becomes really difficult.

I think that such a button could also lead to people sharing more public Diaspora contributions and thus make Diaspora better known.

@jhass
Copy link
Owner

jhass commented Nov 11, 2020

It works with the post guids, so we could quite easily construct https://<currently signed in users hostname>/posts/<guid>, which diaspora currently accepts too on that route. It's just a ton of assumptions in that still :)

@Ravenbird
Copy link
Author

Two guys, one idea. :-)

@tclaus
Copy link
Collaborator

tclaus commented Nov 11, 2020

It then could simply be the platform-specific 'share' button. No frills.

@jhass
Copy link
Owner

jhass commented Nov 11, 2020

I mean we also have the diaspora://<diasporaId>/posts/<guid> (or so, don't quite remember the exact format) custom deeplink, I just doubt a lot of users have that registered :P

@jhass
Copy link
Owner

jhass commented Nov 16, 2020

I'm fine with guessing for now, but nonetheless opened diaspora/api-documentation#58 for handling this properly at some point.

@tclaus
Copy link
Collaborator

tclaus commented Nov 19, 2020

I have prepared something.
PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants