forked from jeremyletang/ears
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow seeking within audio #15
Comments
Just noticed that someone started working on this: hnen@693fef5 |
Yeah, I haven't tested the changes properly and currently am just playing
around. OpenAL seems to fail silently at random when seeking with alSourcef()
if the source is not exactly in the correct state. Also would be nice to
have the seek method on AudioController trait instead of Sound struct and
support it with Music as well (seeking is probably mostly used with music
anyway.)
But yeah if I continue using ears on my project I probably will put some
effort making the routines stable and implement it for Music as well since
I need seeking for music asset anyways. I can do PR even before that but
don't feel 100% comfortable putting in code that doesn't necessarily work
stable enough.
…On Tue, Dec 5, 2017 at 10:35 AM, Jan Niklas Hasse ***@***.***> wrote:
Just noticed that someone started working on this: ***@***.***
<hnen@693fef5>
@hhatinen <https://github.com/hhatinen> Are you planning to also create a
PR? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0GKiydLW6jFwwzOgBY-ZD8KsPNMHS2ks5s9QBdgaJpZM4OZF5k>
.
|
Understandable. Thanks! (and sorry for pinging you out of the blue) |
No problem, happy to collaborate :) Will let you know if/when I get to
finalize the changes.
…On Tue, Dec 5, 2017 at 10:55 AM, Jan Niklas Hasse ***@***.***> wrote:
Understandable. Thanks! (and sorry for pinging you out of the blue)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0GKtCj-htF3b5zf8K28zvSIfb6V0ATks5s9QUVgaJpZM4OZF5k>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Something like a
AudioControllable.seek
would be amazing. Any change to get it implemented? It'd allow making applications that can move back and forth in audio, like a music player. Cheers!The text was updated successfully, but these errors were encountered: