Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveKML only works in north western hemisphere #3

Open
jjguy opened this issue Oct 4, 2012 · 1 comment · May be fixed by #20
Open

saveKML only works in north western hemisphere #3

jjguy opened this issue Oct 4, 2012 · 1 comment · May be fixed by #20

Comments

@jjguy
Copy link
Owner

jjguy commented Oct 4, 2012

saveKML() assumes:

  • the inputs are a set of a (latitude, longitude) coordinates.
  • the minimum latitude is east
  • the maximum latitude is west
  • the minimum longitude is south
  • the maximum longitude is north

These assumptions are only valid in the north western hemisphere. I'm not a GIS guy, but AFAICT, the canonical mechanism to eliminate assumptions is to include N/S and E/W indicators with the coordinate that specifies which hemisphere the coordinate is from.

saveKML needs a mechanism to distinguish; perhaps a second argument that is one of ["NW", "NE", "SW", "SE"].

Thanks to Stephen M for the bug report

@kwauchope
Copy link

I found an issue while playing around with some things today.

The minimum is east is incorrect, it is the maximum. saveKML() has this issue (which I inadvertantly copied and used elsewhere), fixed in my fork. Found it when overriding the area field and wondering why I was getting strange results. Also fixes #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants