Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was the types line in package.json reverted on purpose? #20

Open
hapablap21 opened this issue Jan 19, 2023 · 2 comments
Open

Was the types line in package.json reverted on purpose? #20

hapablap21 opened this issue Jan 19, 2023 · 2 comments

Comments

@hapablap21
Copy link

It was there in 2.2.1 but is now gone in 2.3.0

@oakeef
Copy link

oakeef commented Jun 23, 2023

reading this Pull Request it appears that they were the wrong types?
And then accroding to this reply in a different issue. The types are provided here
They are 2 years old though, so I'm not sure if they are the same types that were removed or not

@capaj
Copy link

capaj commented Jul 19, 2023

yes they were wrong.
If you think you are able to fix them, I think @jkdrangel would gladly accept a PR to do that.
When I did a PR for removal of types I did not have time to fix the types. I had like 10 minutes, so I just forked it, opened the PR and forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants