Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #10

Open
hannobraun opened this issue Aug 30, 2018 · 2 comments
Open

Add integration tests #10

hannobraun opened this issue Aug 30, 2018 · 2 comments
Labels
component: dw1000 Issue concerns the DW1000 driver good first issue Good for newcomers help wanted Extra attention is needed type: enhancement New feature or request

Comments

@hannobraun
Copy link
Contributor

The current unit tests are really not sufficient and a maintenance burden (I'm likely to remove them in an upcoming pull request).

Once embedded-hal is supported, an integration test suite should be added. This issue is currently blocked by #5.

@hannobraun hannobraun added the status: blocked Can't be worked on right now label Aug 30, 2018
@hannobraun
Copy link
Contributor Author

I removed the unit tests in #12, as expected. This doesn't make the crate completely test-less though. There are some examples in the dwm1001 crate that serve as end-to-end tests.

@hannobraun
Copy link
Contributor Author

This crate uses embedded-hal now, which means we can write integration tests and this issue is no longer blocked. I'm not going to tackle that right now though, as the crate is pretty well-tested via the aforementioned examples.

However, having a test suite that can be run without requiring a DWM1001-Dev board would be a great. If anyone were willing to pick this up, I'd appreciate it!

@hannobraun hannobraun added type: enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed status: blocked Can't be worked on right now labels Feb 11, 2019
@hannobraun hannobraun added the component: dw1000 Issue concerns the DW1000 driver label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dw1000 Issue concerns the DW1000 driver good first issue Good for newcomers help wanted Extra attention is needed type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant