Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enum keys of type EnumKey, not int #782

Open
jkomoros opened this issue May 8, 2022 · 0 comments
Open

Make enum keys of type EnumKey, not int #782

jkomoros opened this issue May 8, 2022 · 0 comments

Comments

@jkomoros
Copy link
Owner

jkomoros commented May 8, 2022

Currently keys in Enums are all ints.

It's probably more clear to make them type EnumKey int, just for clarity. For example, GameDelegate.GroupMembership has to explain in documentation what map[int]bool means.

It's a little confusing that a given int isn't guaranteed to be in a given Enum, but at least it's clear what the intent is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant