-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argument parsing for --kube-insecure-skip-tls-verify
broken when used with helm v3.16.4
#492
Comments
Could you run helm --debug secrets and post the output? |
Sure. The output is below. But I really think it might be a general argument parsing issue. Somewhere in the code the handling of this specific flag
|
Sorry for the miscommunication here. Please run the command with --debug
|
|
This is interesting: below is the output of the same command as in the last comment, but with
That is:
Results in:
While
Results in:
|
Current Behavior
Somewhere between helm
v3.15.1
andv3.16.4
, argument parsing for--kube-insecure-skip-tls-verify
got broken when used withhelm-secrets
. I wasn't sure if I should post this issue here or in the helm repository, since it happens by changing only the version of helm itself, but at the same time is triggered only when the helm-secrets plugin is used.Below is the behavior with helm
v3.16.4
:We can of course ignore the "Error: repo bitnami not found", it just means the command syntax actually worked.
What we see is that, with the same arguments,
helm upgrade
works, buthelm secrets upgrade
doesn't work. To fix the issue, we have to force a value on the mentioned flag, as in--kube-insecure-skip-tls-verify=true
. That wan't necessary at least until helmv3.15.1
, as seen below.Expected Behavior
Below is the behavior with helm
v3.15.1
:We can see the command syntax works even when
helm secrets upgrade
is used without any=true
in the flag--kube-insecure-skip-tls-verify
.Steps To Reproduce
Environment
Anything else?
It actually took me quote some time to figure out why my pipeline was broken, since helm's error message of
Error: "helm upgrade" requires 2 arguments Usage: helm upgrade [RELEASE] [CHART] [flags]
is quite far from being helpful and is just thrown in many different situations. But that's just for saying.The text was updated successfully, but these errors were encountered: