Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Total cost label prints the cost with 5 digits of precision after the decimal point. #351

Open
puterboy opened this issue Feb 9, 2024 · 0 comments · Fixed by #353
Open

[BUG]: Total cost label prints the cost with 5 digits of precision after the decimal point. #351

puterboy opened this issue Feb 9, 2024 · 0 comments · Fixed by #353
Labels
enhancement New feature or request solved workaround documented or fix applied
Milestone
1.0.4

Comments

@puterboy
Copy link

puterboy commented Feb 9, 2024

5 digits of precision in costing is clearly excessive given:

  1. The actual power data is only recoreded to 3 digits of precision
  2. Energy bills and costs are usually rounded to the penny anyway (2 digits of precision)

Suggest that label use 2 or at most 3 digtis of precision for the cost.
@jneilliii jneilliii added the enhancement New feature or request label Feb 9, 2024
@puterboy puterboy mentioned this issue Feb 9, 2024
Merged
@jneilliii jneilliii added the solved workaround documented or fix applied label Mar 3, 2024
@jneilliii jneilliii added this to the 1.0.4 milestone Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request solved workaround documented or fix applied
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

Fix rounding in Total Cost trace puterboy/OctoPrint-TPLinkSmartplug
2 participants
@puterboy @jneilliii