Issues with determining whether a player is new for the purposes of character generation

[jnharton]

The current system uses the text "NEW" in the status space to figure this out. Turns out this is really pointless, since chargen (like all editors) sets the status to EDT to indicate that the player is editing something. This occurs right before the check that expects to "NEW" and will otherwise deny use of chargen. So, it will never work, an alternate mechanism will be required.

[jnharton]

Note to self: I will probably have to either create some field on a player that is persisted that indicates this, determine it by some other persisted state/measure or overhaul chargen to use a different system. The latter should be a last resort as using the same system potentially avoids some code duplication.

[jnharton]

Added a boolean variable 'isNew' to help distinguish new players from existing players primarily for the purposes of only allowing character generation once. This is probably a stopgap measure and a few things will need to be tweaked to ensure that existing characters get this toggled false.

--- 9/15/2013

If I set only newly created players isNew value to 'true' and all else to 'false' and don't save any characters who haven't done chargen that might work.

[jnharton]

current status

As noted above, newly created players have 'isNew' set to TRUE and players loaded from the database have 'isNew' set to false. At the moment they are all saved, which needs to be changed (and warnings added).