Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local sources doesn't load #921

Closed
8 tasks done
jareddo-kun opened this issue Aug 5, 2023 · 10 comments
Closed
8 tasks done

Local sources doesn't load #921

jareddo-kun opened this issue Aug 5, 2023 · 10 comments
Labels
Bug Something isn't working

Comments

@jareddo-kun
Copy link

Steps to reproduce

  1. Open 'Browse -> Local source'

Expected behavior

Local files should appear in the library or source

Actual behavior

Local files doesn't show up

Crash logs

No response

Tachiyomi version

1.9.3

Android version

Android 13

Device

Vivo Y35 (V2205)

Other details

Connected to #857
I already cleared the database. Reinstalled the app. Installing on other device. Doesn't work.

Seems like only an SY issue. The original and J2K versions are working.
Might be because of Scoped storage and the "Manage all files" permission is granted on both apps (SY doesn't appear to have that feature when I was going to grant it on device settings)

Acknowledgements

  • This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an extension, I should be opening an issue in the extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 1.9.3.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@jareddo-kun jareddo-kun added the Bug Something isn't working label Aug 5, 2023
@jobobby04
Copy link
Owner

SY doesn't do anything different from main Tachi in regards to storage permissions, from my tests LocalSource works fine

@jferdous70
Copy link

jferdous70 commented Aug 14, 2023

Local sources don't load for me either. Just did a clean reinstall after clearing data and restored backup. No local manga found

Seems to be Sy issue only, can provide video proof if needed

@jareddo-kun
Copy link
Author

SY doesn't do anything different from main Tachi in regards to storage permissions, from my tests LocalSource works fine

Hmm, that's weird. Shouldn't SY work as intended on end device if so? Because it doesn't on both SDK 28 and 33

@jferdous70
Copy link

jferdous70 commented Aug 14, 2023

recording.mp4

Recording for reference

Library manga that were part of local don't appear. If I remove an existing local manga from library, it vanishes completely (and unable to add back, since local doesn't load). Cleared database before and after adding new manga, no effect

@jareddo-kun
Copy link
Author

jareddo-kun commented Aug 14, 2023

At least something loads in your device?

Here's a view of an entry imported from a backup file.
https://github.com/jobobby04/TachiyomiSY/assets/72799720/2094d5c2-9035-4c93-bc17-a92b40edbace

And this is the local source. There should be 9 entries.
https://github.com/jobobby04/TachiyomiSY/assets/72799720/a0d6363a-2b66-4ae3-b536-b2e688613f0f

@jferdous70
Copy link

jferdous70 commented Aug 15, 2023

At least something loads in your device?

Here's a view of an entry imported from a backup file. https://github.com/jobobby04/TachiyomiSY/assets/72799720/2094d5c2-9035-4c93-bc17-a92b40edbace

And this is the local source. There should be 9 entries. https://github.com/jobobby04/TachiyomiSY/assets/72799720/a0d6363a-2b66-4ae3-b536-b2e688613f0f

The local manga that 'loads' was added to library today, so it wasn't part of old backup. Anything that's been around previously don't load no matter what. So it appearing on Latest is an outlier for the most part

@jferdous70
Copy link

jferdous70 commented Aug 15, 2023

SY doesn't do anything different from main Tachi in regards to storage permissions, from my tests LocalSource works fine

Do you have local manga backed up? The appear to vanish when you add them to library.

Here are steps to reproduce the issue

  1. Have existing library with local manga (restored from backup)
  2. Local source doesn't load
  3. Remove all local from library
  4. Clear database
  5. Move local folder to another location on device
  6. Move back local folder to Sy (now local source loads again). Don't restore backup.
  7. Add a local manga to library (local source doesn't load)

If you don't have local manga in backup, you can't reproduce the bug.

@jareddo-kun
Copy link
Author

jareddo-kun commented Aug 15, 2023

Oh my god, I have never felt so dumb before this.

My problem can be solved by using the SY folder instead of the original tachiyomi folder 🤦

The difference between how J2K handled local files was it scans the the original tachiyomi folder (from both local and sd) and create thumbnails in the j2k folder. Would be very helpful if SY does this instead of using a completely separate folder 👍

Anyways, once I fixed it earlier, i tried replicating the bug that jferdous mentioned. I can replicate the bug in my part, too.

@Kupie
Copy link

Kupie commented Sep 21, 2023

Welp, I was searching everywhere to fix this too and...

Turns out I was also putting things in the "Tachiyomi" folder instead of "TachiyomiSY". Feels dumb!

@jobobby04
Copy link
Owner

Going to assume this is fixed with the upcoming changes to load source file handling

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants