Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Bimap return Sets when appropriate #9

Open
recursion-ninja opened this issue Feb 22, 2019 · 1 comment
Open

Make Bimap return Sets when appropriate #9

recursion-ninja opened this issue Feb 22, 2019 · 1 comment

Comments

@recursion-ninja
Copy link

It would be nice if keys and keysR returned Set a instead of [a] by using the Data.Map.keysSet function. Set's are often preferable and this conversion would have a smaller constant factor than Set.fromListAsc . toMap. Plus there's always elems for getting the [a] type.
@joelwilliamson
Copy link
Owner

I would rather have new functions Bimap.keysSet and Bimap.keysSetR so that we can maintain backward compatibility and keep matching the interface of Prelude's Maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelwilliamson @recursion-ninja