From 4777e41f9bd05412c402cb5034cb247767fa42a2 Mon Sep 17 00:00:00 2001 From: Michael Pollmeier Date: Wed, 14 Feb 2024 15:45:31 +0100 Subject: [PATCH] update test comment after clarification (#4158) * project.overlays: RIP available overlays I don't think we still have the concept to selectively enable and disable overlays, do we? N.b. the test has been disabled for ages (not sure if it ever tested anything) * Revert "project.overlays: RIP available overlays" This reverts commit a3dbeb5068b6cbc4a982d8a4145f8b822caf1dff. * test comment after clarification * Update console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala Co-authored-by: David Baker Effendi --------- Co-authored-by: David Baker Effendi --- .../io/joern/console/workspacehandling/WorkspaceTests.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala b/console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala index 5b1930a9455f..0abe2f0887d2 100644 --- a/console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala +++ b/console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala @@ -30,11 +30,11 @@ class WorkspaceTests extends AnyWordSpec with Matchers { output should include(project.name) output should include(inputPath) - // TODO reenable test - this has been broken for ages, the overlays handling via directories works in staged joern but not in our test setup - // what does work in both though is `cpg.metaData.overlays` - I'm asking around which way forward we want + + // This relies on the file system and only works in a staged joern environment, not our workspace + // with a mock cpg. Will leave here just for illustratory purposes. // output should include("foo,bar") } - } }