fix (#79): skip power state for non supported device for get & set thermostat mode #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyirsh
changed the title
|
Thanks for submitting a pull request, @nyirsh! I'm reviewing it now. |
zouma45
reviewed
Jan 1, 2024
| @@ -132,7 +133,15 @@ export default class ThermostatAccessory extends BaseAccessory { | |||
| } | |||
|
|
|||
| async handleTargetStateGet(): Promise<number> { | |||
There was a problem hiding this comment.
I forgot to add the the try catch part for getState indeed, thanks for the update :), looks good to me, I am testing your code on my device too
joeyhage
added a commit
that referenced
this pull request
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #79
The issue was caused by
handlePowerGetnot being able to retrieve the device power state on unsupported devices.The solution proposed by @zouma45 was only implemented on
handleTargetStateSetbut that function was also called byhandleTargetStateGet, so I did implement it in there too.I also made the flag
isPowerSupportedglobal to preventhandlePowerGetbeing called unnecessarily.I did test this by directly modifying the scripts on my homebridge instance and reporting the same changes on the repo but I never coded a plugin for homebridge so I don't know if there is a better way to handle the
isPowerSupportedflag.