Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEL=senzing #12

Open
tomdavidson opened this issue Mar 23, 2023 · 2 comments
Open

MODEL=senzing #12

tomdavidson opened this issue Mar 23, 2023 · 2 comments

Comments

@tomdavidson
Copy link

I'd like to use the senzing model with libpsotal-rest. Looks like it would need its own custom gopostal lib. Interested in supporting the option? I hardly have any go experience but could try a PR? How would you like it to look?

@johnlonganecker
Copy link
Owner

Hmm great question, it seems like you would need to add the MODEL=senzing to this line https://github.com/johnlonganecker/libpostal-rest-docker/blob/master/build_libpostal.sh#L4

I am not in touch with libpostal lately but I do try to help out when/where I can. Is there any downsides to adding this in? IE it will make it not work for some countries?

@tomdavidson
Copy link
Author

tomdavidson commented Mar 28, 2023

any downsides to adding this

I dont have data to say one way or another but I assume if its optimized for USA addresses that there was a take for non-USA addresses.

If its just the build script in the docker packaging then I can just bake my own image. I had thought it had been ported to go in gopostal and we needed to make libpostal-rest have an option to import a different lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants