Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular - exception-handler-provider error during minification #81

Open
ManojShenoy25 opened this issue Mar 2, 2016 · 2 comments
Open

Comments

@ManojShenoy25
Copy link

Dependencies for the exception handler provider are not minification safe and throw an error when I use the default aspnet bundling & minification.

Refer Line 48 in file below
https://github.com/johnpapa/ng-demos/blob/master/modular/src/client/app/blocks/exception/exception-handler.provider.js

$delegate, exceptionHandler, logger dependencies for "extendExceptionHandler" function should be injected using $inject service .

@ingcrengifo
Copy link

you've corrected? I would like to update my code.

@ManojShenoy25
Copy link
Author

What I have done is inject the dependencies using the $inject service just before the extendExceptionHandler function. Once this was done I was able to bundle and minify without trouble.

extendExceptionHandler.$inject = ['$delegate', '$exceptionHandler','logger'];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants