-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3 #161
Comments
Thank you for bringing this to my attention, @allerter. As is probably apparent, I have not been following any rigorous system for versioning changes. I like your suggestion of 3.0 after merging the outstanding PRs and following Semantic Versioning after that point forward. A question on your upcoming PR though: do you intend to do away with the token entirely? This is not a direction I'd like to head in, as I'd like to use Genius's authorized API calls whenever possible. |
I don't intend to remove the tokens entirely, but only to make them optional. As for API-only methods, there is no way to use them without a token. And for PublicAPI-only methods, it doesn't matter if there's a token. And for methods that support both APIs, this is basically what it boils down to:
So the PublicAPI is only used when the user explicitly sets |
Okay, I like that approach! If a user creates an instance of the |
The
|
Yes, the PR for making the token optional is almost ready. |
I agree. The VCR testing would be especially helpful. |
There was an |
Committing my changes using GitHub Desktop completely threw me off track. There's also another issue that the |
Shoot, sorry about those mistakes! I was a little careless while merging through the web interface. I'd suggest opening a new PR that resolves the errors you've described here. We'll merge that, then can move forward with 3.0. What do you think? |
Sure, that's a good approach. After merging that PR, should we also merge #109? |
Yes, let's merge #109 before doing 3.0. |
Version 2.0.2 that was just released on PyPi introduces new features and more importantly breaking changes. If we were to follow Semantic Versioning, 2.0.2 probably should've been 3.0.
Supposing we merge #156, #158, #159, and another one I have coming where Genius no longer needs a token (I should've actually implemented that in #160), what version do you think it should be? We could go for 2.1.0 which is against Semantic Versioning, or 3.0?
I'd love to hear your thoughts on this.
The text was updated successfully, but these errors were encountered: