Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

road_address for ko_KR locale should be changed #2132

Open
semi-yu opened this issue Nov 2, 2024 · 0 comments · May be fixed by #2133
Open

road_address for ko_KR locale should be changed #2132

semi-yu opened this issue Nov 2, 2024 · 0 comments · May be fixed by #2133

Comments

@semi-yu
Copy link

semi-yu commented Nov 2, 2024

  • Faker version: 30.8.2
  • OS: Windows 11 Pro (22H2) -- does not matter.

The road_address provider in locale 'ko_KR' should also generate building-number (건물 번호). Which noted in the source code comments but actually are not generated in result.

Expected behavior

With a locale 'ko_KR', address() method should generate road addresses such as: "서울특별시 중구 세종대로 110", or "서울특별시 용산구 서빙고로 137" which provides 'building numbers' at the end of the address.

Actual behavior

With a current version of Faker, faker only generates fake addresses without building numbers such as" "대전광역시 강서구 석촌호수거리", "전라남도 용인시 수지구 개포65길".

@semi-yu semi-yu linked a pull request Nov 2, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant