Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cross-post] Inconsistencies and Holes with Grammar documentation #1

Closed
Forthoney opened this issue Nov 20, 2023 · 3 comments
Closed

Comments

@Forthoney
Copy link

I found some problems with the syntax.md document on the RBS repo. I think the ones that specifically relate to this project would be the missing definitions for record-name and members. As I understand, this project uses a reasonable but technically non-canon definitions for these grammar elements. It would be great to keep an eye out for updates on the official RBS syntax.md documents, and update definitions on this project accordingly

@Forthoney
Copy link
Author

As a side note, I would like to contribute to officially bringing this to nvim-treesitter. Would there be issues besides this one that need to be resolved before making a language addition request to nvim-treesitter?

@joker1007
Copy link
Owner

Thank you for your comments!
I also think that syntax.rb of the rbs repository does not satisfy all grammers.
I wrote this tree-sitter parser with experimentation on actual steep and rbs behavior.
I will continue to follow the official syntax definitions as I possible.

And, I also wanted to bring this to nvim-treesitter repository.
For now, I'm checking parser errors and debugging.
Well, It probably does not have a practical problem.
And so, If you will contribute to nvim-treesitter, I welcome you!

Thank you so much!

@Forthoney
Copy link
Author

No problem! I'm just doing the administrative work 😅 Here is the request I made. I will keep an eye out for any significant updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants