Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http(s) checking for the inputted URL. #6

Open
jonchenn opened this issue Jul 9, 2019 · 0 comments
Open

Add http(s) checking for the inputted URL. #6

jonchenn opened this issue Jul 9, 2019 · 0 comments
Assignees

Comments

@jonchenn
Copy link
Owner

jonchenn commented Jul 9, 2019

The code breaks when passing a URL without http(s).
E.g.

./amp-prototyper www.dickies.com/

This returns
jonchen@jonchen02:~/workspace/amp-prototyper$ ./amp-prototyper www.dickies.com TypeError: Cannot read property '0' of null at amplifyFunc (/usr/local/google/home/jonchen/workspace/amp-prototyper/src/core.js:349:61) at amplify (/usr/local/google/home/jonchen/workspace/amp-prototyper/src/core.js:481:11) at <anonymous> at process._tickCallback (internal/process/next_tick.js:189:7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants