Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align FlameGraph color scheme to match original Perl script output #327

Open
jamel opened this issue Jul 23, 2024 · 1 comment
Open

Align FlameGraph color scheme to match original Perl script output #327

jamel opened this issue Jul 23, 2024 · 1 comment

Comments

@jamel
Copy link

jamel commented Jul 23, 2024

I'm developing an internal tool to capture performance data and generate flame graph SVGs. This tool aims to replace a set of scripts with a single executable featuring user-friendly sub-commands. The inferno library is working great, and I appreciate your effort in creating it! However, the coloring scheme of the produced SVGs differs from the original flamegraph.pl script, which has led to complaints from colleagues accustomed to the previous color scheme.

What do you think about one of this?

  • modify the library to match the original flamegraph.pl coloring scheme. This would ensure consistency with the color scheme familiar to existing users.
  • introduce an additional Palette option that can be used to replicate the original flamegraph.pl color scheme. This would provide flexibility for users who prefer the original color scheme while preserving the current default scheme.
@jonhoo
Copy link
Owner

jonhoo commented Jul 27, 2024

I'm interested to hear in what way it diverges — in general, this was a pretty direct port, including the color selection. It may however be that we've iterated further beyond the original flamegraph since then. Could you post some images of the differences?

Overall I'd be happy to include a palette that replicates the original 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants