Replies: 9 comments 1 reply
-
Please test and confirm that you have he same issue when using the joomla admin template and not the one from joomlashine |
Beta Was this translation helpful? Give feedback.
-
I can reproduce it on current staging with the Isis template: |
Beta Was this translation helpful? Give feedback.
-
I have just double checked the Joomlashine template issue. It was their system plugin adding Alsojust notices that there is |
Beta Was this translation helpful? Give feedback.
-
Easy to handle if it is really needed. With com_contact for example, just add two lines of code below before this line https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_contact/controller.php#L42 and it should work as expected: $this->input->set('view', $view);
$this->input->set('layout', $layout); |
Beta Was this translation helpful? Give feedback.
-
this issue is with all components, not just
|
Beta Was this translation helpful? Give feedback.
-
We can handle it in display method of BaseController class. Adding these lines of code below after this line https://github.com/joomla/joomla-cms/blob/staging/libraries/src/MVC/Controller/BaseController.php#L619 $this->input->set('view', $viewName);
$this->input->set('layout', $viewLayout); And that should work for all components. But I'm unsure if it is safe to do that. |
Beta Was this translation helpful? Give feedback.
-
What is the problem you are trying to solve |
Beta Was this translation helpful? Give feedback.
-
thats an easy one.
this changes the background globaly in the admin for my component body.com_qwupdateserver {
background: #f9f9f9;
} the next logical step is to use a page specific CSS body.view-dashboard {
background: #f9f9f9;
} Solutions
On a personal note i want all of my CSS and code to be neat and tidy and I dont like broken code. 😄 |
Beta Was this translation helpful? Give feedback.
-
What a waste of my time. I report something that is clearly a bug and it just gets moved to discussions with no explanation, brilliant. @rdeutz Why did you close this and move it to discussions? Is this the new MO of Joomla, move issues to discussions and not tell anyone why? |
Beta Was this translation helpful? Give feedback.
-
Steps to reproduce the issue
In the admin area, go to any components default view by clicking on it's primary link:
When you load the components default view the following classes are incomplete in the
<body>
tag declaration, you get instead:and as you can see the names of the view and layout are missing part of the class declaration which means you cannot do 'page / view / layout' specific CSS styling when it is loaded as a default view.
If you load
https://localhost/platforms/joomla3/administrator/index.php?option=com_contact&view=contacts
then the view class is correctly formed as view-contacts. However the layout is still incomplete probably because the layout is default.Expected result
Actual result
System information (as much as possible)
Additional comments
This is an issue in Joomla 3 but I have checked in joomla 4 and get the following notes. I also again used com_contacts and the example
joomla4/administrator/index.php?option=com_contact
<body>
tag but with view-sysinfo which is new over Joomla 3 and again layout- + there is now task-<body class=" jsn-master tmpl-isis admin com_admin view-sysinfo layout- task- itemid-0" data-basepath="/platforms/joomla3">
joomla4/administrator/index.php?option=com_contact
I now get a different<body>
tag<body class="admin com_contact view- layout-default task-display">
this now has the layout show correctly with default but the view is now missing part of the class name
Sidemenu --> Components -->Contacts --> Contacts
I get the following<body>
tag<body class="admin com_contact view-contacts layout-default task-display">
Conclusion
What this means is there is some inconsistencies with how these class names are created but has been partially fixed in Joomla 4.
This is not a show stopper but definately should be one of those things fixed in Joomla 4 if not in Joomla 3.
Beta Was this translation helpful? Give feedback.
All reactions