Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on browser-shims.js #7

Open
pdeva opened this issue Jul 2, 2014 · 1 comment
Open

remove dependency on browser-shims.js #7

pdeva opened this issue Jul 2, 2014 · 1 comment

Comments

@pdeva
Copy link

pdeva commented Jul 2, 2014

the browser-shims.js file adds functions to some of the core classes of javascript. this make it unaccpetable to use the name parser library in a large project where we dont want a 3rd party lib to modify core behavior in any way.

if you reduce the dependency it will make the library acceptable to use in many, many more scenarios.

@cbojar
Copy link

cbojar commented Jul 2, 2014

The browser-shims.js file adds functionality that is present in modern versions of Javascript (String#trim:ES5.1, Array#indexOf:ES5.1, Array#filter:ES5.1, Array#map:ES5.1). They are there to provide these modern capabilities to very old browsers (most notably IE <= 8), and their use is common. Because they are standards, other libraries will not conflict with them (except to potentially provide the exact same shims). Where the core behavior already exists, the script does nothing. Removing them as a dependency will only make the code much more complex to achieve the same result, and will be a step backwards in terms of applying modern standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants