Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Types] Add Howler types as optional peer dependency #130

Open
jdeblasse opened this issue Apr 18, 2023 · 0 comments
Open

[Types] Add Howler types as optional peer dependency #130

jdeblasse opened this issue Apr 18, 2023 · 0 comments

Comments

@jdeblasse
Copy link

Consider changing your package.json file to have @types/howler as a peer dependency that's optional. Optional is important because not everyone uses Typescript.

You package.json would then look something like this (depends on your deps conventions for SEMVER et al):

  "peerDependencies": {
    "react": ">=16.8",
    "@types/howler": "^2.1.0",
  },
  "peerDependenciesMeta": {
    "@types/howler": {
      "optional": true
    }
  }

This will let users know that it's a recommended peer dependency when adding to their projects. This will resolve some of the repetitive open issues with regards to missing type definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant