Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way for links to be more prominent on a page #4428

Closed
1 task done
joshwooding opened this issue Nov 20, 2024 · 5 comments
Closed
1 task done

Provide a way for links to be more prominent on a page #4428

joshwooding opened this issue Nov 20, 2024 · 5 comments
Assignees
@pseys
Labels
component: link groomed pokemon type: enhancement 💡 New feature or request

Comments

@joshwooding
Copy link
Contributor

joshwooding commented Nov 20, 2024 •
edited
Loading

Tasks
Preview Give feedback
  1. Add accented Links #4662
    pseys

Description

Link currently supports matching text color but there's no way to make it more prominent other than that #4283 is one solution but maybe a accented link is also fine?

  • This link is for inline body links
  • Provide an accent link (without an underline)
  • Consider visited state, whether it's maps to the same styles or can be independently styled.
  • Consider breaking out, based on priority/value and moving secondary work to backlog (visited support)

The color version can be delivered in Oregano

Expected behavior

.

Alternatives and examples

image

Context

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@joshwooding joshwooding added type: enhancement 💡 New feature or request status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Nov 20, 2024
@joshwooding joshwooding added component: link and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Nov 20, 2024
@bhoppers2008
Copy link

Related to #4526

@bhoppers2008 bhoppers2008 mentioned this issue Jan 7, 2025
Closed
@pseys pseys self-assigned this Jan 9, 2025
@pseys
Copy link
Contributor

pseys commented Jan 9, 2025

@dplsek this is related to #4526 – the suggestion is that the 'default' link colour could be changed to accent, providing us with a primary and secondary option for Link. If we're updating the hover and active states to match accent it makes sense to do this task at the same time, but I wanted your thoughts on it first.

@mark-tate
Copy link
Contributor

Oregano Goal: known plan by EOS

@mark-tate
Copy link
Contributor

proposal to be shared by next standup

@mark-tate
Copy link
Contributor

Josh has added accent color to link
PR merged by EOS

@pseys pseys added the pokemon label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pseys pseys

Labels
component: link groomed pokemon type: enhancement 💡 New feature or request
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mark-tate @joshwooding @bhoppers2008 @pseys