Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymization of trajectory logs incomplete for v4.0 #399

Open
keithoffer opened this issue Jul 8, 2021 · 1 comment
Open

Anonymization of trajectory logs incomplete for v4.0 #399

keithoffer opened this issue Jul 8, 2021 · 1 comment

Comments

@keithoffer
Copy link
Contributor

I noticed that while #161 added support for reading the new metadata fields, the anoymize log features weren't updated to remove the patient information. Unfortunately due to the strange way they setup that metadata field, there is no clear offset for the patient ID, so the whole metadata field will probably have to be read, adjusted, and then written with an anoymised patient ID.

Also, once the patient ID is written the CRC at the end of the file should probably be updated. From what I can tell, binascii.crc_hqx(insert_all_bytes_here,0xFFFF) should generate the right CRC.

@jrkerns
Copy link
Owner

jrkerns commented Jul 28, 2021

Varian's implementation of metadata is indeed a bit strange but I should able to remove it. Thanks for the tip on CRC; I never worked on updating it because I was not aware of any software checking it after post-processing. I'll split these into two separate tickets.

jrkerns added a commit that referenced this issue Jun 10, 2024
adjust the fine-tuning limitations

Approved-by: Randy Taylor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants