Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMATBase _median_profiles function returning mean profiles #483

Open
keithoffer opened this issue Feb 27, 2024 · 1 comment
Open

VMATBase _median_profiles function returning mean profiles #483

keithoffer opened this issue Feb 27, 2024 · 1 comment

Comments

@keithoffer
Copy link
Contributor

I'm unsure if I'm reading things incorrectly, but in the VMATBase class (used for DRMLC and DRGS analysis), as far as I can tell, the _median_profiles() method is actually returning mean profiles. In particular, this line calls np.mean on the images, not np.median which is what I'd expect. However going back through the history, it looks like it's always been like this?

@jrkerns
Copy link
Owner

jrkerns commented Apr 5, 2024

Yup, looks like a naming thing. Mean works better IMO in the event the field is narrower in the Y than the background. I.e. if the field were only 10cm tall on a 40cm EPID, the median would be the background value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants