Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a task showing usage of if with nontrivial schema #71

Open
erosb opened this issue Aug 22, 2024 · 3 comments
Open

Add a task showing usage of if with nontrivial schema #71

erosb opened this issue Aug 22, 2024 · 3 comments
Labels
📝 Documentation Improvements or additions to documentation Status: Available No one has claimed responsibility for resolving this issue.

Comments

@erosb
Copy link
Collaborator

erosb commented Aug 22, 2024

Suggested by Sandrina Pereira on Slack:

Still about Conditionals, at Remote most engineers struggle to understand what's possible in if schemas. They think it's just const, but it's basically anything really. minimum, contains, pattern, not, etc. So an extra example showing it would be useful.

@JeelRajodiya JeelRajodiya added the 📝 Documentation Improvements or additions to documentation label Aug 25, 2024
@JeelRajodiya JeelRajodiya added the Status: Available No one has claimed responsibility for resolving this issue. label Sep 29, 2024
@LasneF
Copy link

LasneF commented Oct 18, 2024

even more the sample provided looks wrong ! it misses that required : ["isFullTime"]

that is not obvious at all as we could think that the properties make it mandatory (by magic :) )

{
  "type": "object",
  "properties": {...},
  "if": {"properties": {"isFullTime": {"const": true}}},
  "then": {"required": ["salary"]},
}

@jdesrosiers
Copy link
Member

even more the sample provided looks wrong ! it misses that required : ["isFullTime"]

This should be a separate issue. This was addressed in #62 and #95, but apparently there was still a place it didn't get fixed.

@JeelRajodiya
Copy link
Member

I am currently busy with my academics, I will address these issues once I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Improvements or additions to documentation Status: Available No one has claimed responsibility for resolving this issue.
Projects
None yet
Development

No branches or pull requests

4 participants