Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Erlang OTP 27.1 #128

Open
fishtreesugar opened this issue Sep 18, 2024 · 1 comment · May be fixed by #129 or #118
Open

Regression in Erlang OTP 27.1 #128

fishtreesugar opened this issue Sep 18, 2024 · 1 comment · May be fixed by #129 or #118

Comments

@fishtreesugar
Copy link

fishtreesugar commented Sep 18, 2024

In the pull request at erlang/otp#8537, specifically in commit erlang/otp@8d537f5, the CWD is rebuilt using filename:join/2. However, dest_path was not converted from binary to charlist:

xlsxir/lib/xlsxir/unzip.ex

Lines 153 to 154 in 4dbebf2

defp extract_from_zip(path, file_list, :memory), do: :zip.extract(path, [{:file_list, file_list}, :memory])
defp extract_from_zip(path, file_list, {:file, dest_path}), do: :zip.extract(path, [{:file_list, file_list}, {:cwd, dest_path}])

As a result, filename:join/2 returns a binary filename that fails to concatenate with TrailingSlash, which is a charlist: https://github.com/erlang/otp/blob/94d3cd6/lib/stdlib/src/zip.erl#L2330

@neilberkman
Copy link

Just came here to report the same issue!

fishtreesugar added a commit to fishtreesugar/xlsxir that referenced this issue Sep 18, 2024
@fishtreesugar fishtreesugar linked a pull request Sep 18, 2024 that will close this issue
nathany-copia pushed a commit to copia-wealth-studios/xlsxir that referenced this issue Sep 26, 2024
@nathany-copia nathany-copia linked a pull request Sep 26, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants