Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passport plugin doesn't use defined authModel #19

Open
oori opened this issue Apr 23, 2014 · 3 comments · May be fixed by #21
Open

passport plugin doesn't use defined authModel #19

oori opened this issue Apr 23, 2014 · 3 comments · May be fixed by #21

Comments

@oori
Copy link
Contributor

oori commented Apr 23, 2014

https://github.com/jspears/bobamo/blob/master/plugins/passport/passport.js#L14
is missing something like this after it:

if (this.options.authModel) this.conf.authModel = this.options.authModel.modelName;

Should I send you a PR? I'm not sure if that's the intended way for this to work... this repo is a bit of a mess.. (yet, useable :-))

@oori
Copy link
Contributor Author

oori commented Apr 23, 2014

This commit had something like this in the past:
2803f88#diff-7de939b1fb25607245c250c3447b3f2cR36

@jspears
Copy link
Owner

jspears commented Apr 23, 2014

Yeah send a pr. Thanks! I'll prolly merge tonight

Sent from my iPhone

On Apr 23, 2014, at 10:56 AM, Oori [email protected] wrote:

https://github.com/jspears/bobamo/blob/master/plugins/passport/passport.js#L14
is missing something like this after it:

if (this.options.authModel) this.conf.authModel =
this.options.authModel.modelName;

Should I send you a PR? I'm not sure if that's the intended way for this to
work... this repo is a bit of a mess.. (yet, useable :-))


Reply to this email directly or view it on
GitHubhttps://github.com//issues/19
.

@oori oori linked a pull request Apr 23, 2014 that will close this issue
@oori
Copy link
Contributor Author

oori commented May 10, 2014

tonight ? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants