Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parseUrlpkg from @jspm/generator #14

Open
JayaKrishnaNamburu opened this issue Aug 27, 2023 · 1 comment · May be fixed by #17
Open

Replace parseUrlpkg from @jspm/generator #14

JayaKrishnaNamburu opened this issue Aug 27, 2023 · 1 comment · May be fixed by #17
Labels
good first issue Good for newcomers

Comments

@JayaKrishnaNamburu
Copy link
Member

The main reason for using this, is to create file names using packagename@version. So we use parseUrlPkg from the @jspm/generator. Again as i mentioned in #13 to keep the loader lean. Let's see if we can do the check in the loader itself.

Reason

  • We are currently not bundling the loader along with it's dependencies and distributing to npm. So, that makes the users to download the whole @jspm/generator every-time they download the loader too. Give the use-case for extracting name and version, this is something we can avoid downloading.
@JayaKrishnaNamburu JayaKrishnaNamburu added the good first issue Good for newcomers label Aug 27, 2023
@yowainwright
Copy link
Member

I can re-add this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants