From 909cb9a76819ebdc4156e48142bf2ca0ca7f1a33 Mon Sep 17 00:00:00 2001
From: cchang-vassar <79338042+cchang-vassar@users.noreply.github.com>
Date: Fri, 13 Sep 2024 09:45:27 -0400
Subject: [PATCH] fix build citation rollup plugin to actually generate
 citation

---
 packages/config/rollup-plugin-build-citation.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/config/rollup-plugin-build-citation.js b/packages/config/rollup-plugin-build-citation.js
index 0100e41273..2deaaac569 100644
--- a/packages/config/rollup-plugin-build-citation.js
+++ b/packages/config/rollup-plugin-build-citation.js
@@ -22,7 +22,7 @@ export default function cffToJsonPlugin() {
       // Try to find CITATION.cff file
       const citationCff = (() => {
         try {
-          fs.readFileSync("./CITATION.cff", "utf-8").toString();
+          return fs.readFileSync("./CITATION.cff", "utf-8").toString();
         } catch (error) {
           console.log(`Error finding CITATION.cff: ${error.message}`);
           return null;
@@ -42,13 +42,15 @@ export default function cffToJsonPlugin() {
             2
           );
         } catch (error) {
-          console.log(`Error building citation from CITATION.cff: ${error.message}`);
+          console.log(`Error converting CITATION.cff to JSON: ${error.message}`);
           return null;
         }
       })();
 
       // Replace target string with citation JSON
-      if (!citationJson) return { code: code };
+      if (!citationJson) {
+        return { code: code };
+      }
       const citationString = "citation: " + citationJson;
       const startIndex = code.indexOf(targetString);
       if (startIndex !== -1) {