Fully implement datafy

[huahaiy]

1. inconsistency

In the docstring of datalevin.core/entity it says:
If entity does not exist, nil is returned:

(entity db 100500) ; => nil

however, if I try to call e.g. (d/entity conn 999999999999999999) I just get back
{:db/id 999999999999999999}

2. implement datafy on entity

[huahaiy]

datafy appears to be implemented already on pulled entities. See datalevin.test.datafy

[huahaiy]

We will keep existing behavior and correct the doc string instead.

[simongray]

@huahaiy I don't think Datafy is implemented or at least I am unable to touch an entity and get data back (I still get one of Datalevin's internal types):

(type (clojure.datafy/datafy (d/touch (d/entity (d/db (d/get-conn db-path schema)) 1))))
=> datalevin.entity.Entity

[huahaiy]

What are these tests then? https://github.com/juji-io/datalevin/blob/master/test/datalevin/test/datafy.clj

PR welcome.

[simongray]

Seems like nav is implemented, but not datafy.

[huahaiy]

PR welcome!

[den1k]

It is on entity but it seems the ns is not required anywhere

impl:

datalevin/src/datalevin/datafy.clj

Line 2 in 397ba2c

"Implement Clojure Datafiable protocol for entities"

missing require: https://github.com/search?q=repo%3Ajuji-io%2Fdatalevin%20datalevin.datafy&type=code

[huahaiy]

Would requiring this ns in datalevin.core help?

[den1k]

Yes I think that's all that's needed

…

On Wed, Dec 18, 2024 at 9:25 PM Huahai Yang ***@***.***> wrote: Would requiring this ns in datalevin.core help? — Reply to this email directly, view it on GitHub <#292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDPWIVQCH7INVGDKR4GTHT2GIVBBAVCNFSM6AAAAABRHLKPLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJSGY2DAMRXGA> . You are receiving this because you commented.Message ID: ***@***.***>

[huahaiy]

Done.

[den1k]

thank you!

…

On Fri, Dec 20, 2024 at 9:21 AM Huahai Yang ***@***.***> wrote: Done. — Reply to this email directly, view it on GitHub <#292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDPWIW3D3S4EOEQ4EKI2U32GQRV3AVCNFSM6AAAAABRHLKPLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJXGEYDONZWGI> . You are receiving this because you commented.Message ID: ***@***.***>