From 9484ee697e710b65d780334306377d79e12d0684 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Thu, 4 Apr 2024 10:53:56 +0200 Subject: [PATCH 1/6] Remove old versions from github workflow Fixes #377 --- .github/workflows/build.yml | 53 +++---------------------------------- 1 file changed, 3 insertions(+), 50 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2870ea7c..117e3753 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -28,14 +28,12 @@ jobs: strategy: fail-fast: false matrix: - node: [15.7.0, 16.11.1, 17.6.0, 18.8.0, 19.0.0, 20.0.0, 21.0.0] + node: [17.6.0, 18.8.0, 19.0.0, 20.0.0, 21.0.0] include: - architecture: arm64 architecture_node: x64 target_architecture: arm64 extra_compile_flags: -march=armv8-a - - python_version: 3 - node: 16.11.1 - python_version: 3 node: 17.6.0 - python_version: 3 @@ -82,10 +80,8 @@ jobs: strategy: fail-fast: false matrix: - node: [15.7.0, 16.11.1, 17.6.0, 18.8.0, 19.0.0, 20.0.0, 21.0.0] + node: [17.6.0, 18.8.0, 19.0.0, 20.0.0, 21.0.0] include: - - python_version: 3 - node: 16.11.1 - python_version: 3 node: 17.6.0 - python_version: 3 @@ -168,11 +164,6 @@ jobs: 17.2.0, 17.1.0, 17.0.0, - 16.0.1, - 15.3.0, - 15.2.0, - 15.1.2, - 15.0.0, ] include: - electron_mocha_version: ^11 @@ -187,8 +178,6 @@ jobs: - architecture: x64 architecture_node: x64 target_architecture: x64 - - architecture: x64 - node: 16.13.2 - electron: 25.3.0 node: 18.15.0 - electron: 25.2.0 @@ -245,38 +234,6 @@ jobs: node: 16.15.0 - electron: 20.0.3 node: 16.15.0 - - electron: 19.1.0 - node: 16.14.2 - - electron: 19.0.0 - node: 16.14.2 - - electron: 18.3.0 - node: 16.13.2 - - electron: 18.2.0 - node: 16.13.2 - - electron: 18.1.0 - node: 16.13.2 - - electron: 18.0.0 - node: 16.13.2 - - electron: 17.4.0 - node: 16.13.0 - - electron: 17.3.0 - node: 16.13.0 - - electron: 17.2.0 - node: 16.13.0 - - electron: 17.1.0 - node: 16.13.0 - - electron: 17.0.0 - node: 16.13.0 - - electron: 16.0.1 - node: 16.9.1 - - electron: 15.3.0 - node: 16.5.0 - - electron: 15.2.0 - node: 16.5.0 - - electron: 15.1.2 - node: 16.5.0 - - electron: 15.0.0 - node: 16.5.0 exclude: - os: macos-11 architecture: ia32 @@ -341,14 +298,10 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, macos-11, windows-2019] - node: [15.7.0, 16.11.1, 17.6.0, 18.8.0, 19.0.0, 20.0.0] + node: [17.6.0, 18.8.0, 19.0.0, 20.0.0] architecture: [x64, ia32, arm64] include: - python_version: "3.10" - - node: 15.7.0 - python_version: "3.6" - - node: 16.11.1 - python_version: "3.6" - architecture: ia32 architecture_node: x86 target_architecture: ia32 From 29f99147f727835ca38f364ad8cc908a2ec50e39 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Thu, 4 Apr 2024 10:55:01 +0200 Subject: [PATCH 2/6] Fix empty branch property in github workflow --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 117e3753..6a9ba96e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -7,7 +7,6 @@ on: - "2.*" - "3.*" - "4.*" - branches: pull_request: workflow_dispatch: From 707591f8d107aae65272cccdf40310b200311849 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Thu, 4 Apr 2024 10:55:37 +0200 Subject: [PATCH 3/6] Update engine in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0ead74cc..767d7018 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "main": "./lib/index.js", "types": "./muhammara.d.ts", "engines": { - "node": ">=15" + "node": ">=16" }, "scripts": { "install": "node-pre-gyp install --fallback-to-build ${EXTRA_NODE_PRE_GYP_FLAGS:-\"\"}", From 6a56ded76e5327c7d04a188523febc857bd28e43 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Thu, 4 Apr 2024 12:03:34 +0200 Subject: [PATCH 4/6] Remove even more electron versions --- .github/workflows/build.yml | 49 ------------------------------------- 1 file changed, 49 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6a9ba96e..1a9bdb0a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -140,29 +140,6 @@ jobs: 23.1.0, 23.0.0, 22.3.0, - 22.2.0, - 22.1.0, - 22.0.0, - 21.4.0, - 21.3.0, - 21.2.0, - 21.1.0, - 21.0.0, - 20.3.3, - 20.2.0, - 20.1.0, - 20.0.3, - 19.1.0, - 19.0.0, - 18.3.0, - 18.2.0, - 18.1.0, - 18.0.0, - 17.4.0, - 17.3.0, - 17.2.0, - 17.1.0, - 17.0.0, ] include: - electron_mocha_version: ^11 @@ -207,32 +184,6 @@ jobs: node: 18.12.1 - electron: 23.0.0 node: 18.12.1 - - electron: 22.3.0 - node: 16.17.1 - - electron: 22.2.0 - node: 16.17.1 - - electron: 22.1.0 - node: 16.17.1 - - electron: 22.0.0 - node: 16.17.1 - - electron: 21.4.0 - node: 16.16.0 - - electron: 21.3.0 - node: 16.16.0 - - electron: 21.2.0 - node: 16.16.0 - - electron: 21.1.0 - node: 16.16.0 - - electron: 21.0.0 - node: 16.16.0 - - electron: 20.3.3 - node: 16.15.0 - - electron: 20.2.0 - node: 16.15.0 - - electron: 20.1.0 - node: 16.15.0 - - electron: 20.0.3 - node: 16.15.0 exclude: - os: macos-11 architecture: ia32 From eb1d642880b964e282330da3b284aab466b03924 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Thu, 4 Apr 2024 12:04:07 +0200 Subject: [PATCH 5/6] Raise node min engine version in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 767d7018..2ea36f60 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "main": "./lib/index.js", "types": "./muhammara.d.ts", "engines": { - "node": ">=16" + "node": ">=17" }, "scripts": { "install": "node-pre-gyp install --fallback-to-build ${EXTRA_NODE_PRE_GYP_FLAGS:-\"\"}", From d938a35b39fac3d178925f8e261c76d8f2a46ce3 Mon Sep 17 00:00:00 2001 From: Julian Hille Date: Fri, 5 Apr 2024 08:05:17 +0200 Subject: [PATCH 6/6] fix Missing removed line --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1a9bdb0a..b6480119 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -139,7 +139,6 @@ jobs: 23.2.0, 23.1.0, 23.0.0, - 22.3.0, ] include: - electron_mocha_version: ^11