Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported functions with no doc #1825

Closed
17 tasks
blegat opened this issue Feb 4, 2019 · 3 comments
Closed
17 tasks

Exported functions with no doc #1825

blegat opened this issue Feb 4, 2019 · 3 comments

Comments

@blegat
Copy link
Member

blegat commented Feb 4, 2019

Edit(odow): updated 31-03-2021

  • MOI
  • MOIB
  • MOIU
  • VariableNotOwnedError
  • moi_add_constraint
  • moi_add_to_function_constant
  • parse_SD_constraint
  • parse_SD_constraint_expr
  • parse_constraint
  • parse_constraint_expr
  • parse_constraint_head
  • parse_one_operator_constraint
  • parse_ternary_constraint
  • parse_ternary_variable
  • parse_variable
  • variable_type
  • vectorize

Script

deprecated = [
    :getdual,
    :getobjectivebound,
    :getobjectivevalue,
    :getvalue,
    :linearterms,
    :numnlconstr,
    :numvar,
    :set_coefficient,
    :set_parameter,
    :set_parameters,
    :setlowerbound,
    :setupperbound,
    :setvalue,
    :solve,
    :with_optimizer,
    :writeLP,
    :writeMPS,
]
for name in filter(n -> !(n in deprecated), names(JuMP))
    f = getfield(JuMP, name)
    s = Base.Docs.doc(f)
    if s.content[1].content[1] == "No documentation found."
        println(" - [ ] `", name, "`")
    end
end
@odow odow added this to the 0.19 milestone Feb 11, 2019
@blegat
Copy link
Member Author

blegat commented Feb 12, 2019

Isn't the 1.0 milestone more appropriate ? This is not a regression from v0.18

@mlubin
Copy link
Member

mlubin commented Feb 12, 2019

Of these, I'd say that only index and optimizer_index need to be documented for 0.19. The rest are not that essential for typical usage.

@odow
Copy link
Member

odow commented Oct 4, 2021

With #2731 the list is now

  • MOI
  • MOIB
  • MOIU
  • parse_SD_constraint
  • parse_SD_constraint_expr
  • parse_constraint
  • parse_constraint_expr
  • parse_constraint_head
  • parse_one_operator_constraint
  • parse_ternary_constraint
  • parse_ternary_variable
  • parse_variable
  • vectorize

The parse_ methods can be covered by #2236
The MOI structs can be covered by #1789

Therefore, I'm going to close this issue.

@odow odow closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants