Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15 release notes include things which were merged in 2.14 #1490

Open
krassowski opened this issue Jan 15, 2025 · 5 comments
Open

2.15 release notes include things which were merged in 2.14 #1490

krassowski opened this issue Jan 15, 2025 · 5 comments
Labels

Comments

@krassowski
Copy link
Collaborator

The 2.15 release contains on 15 PRs v2.14.2...v2.15.0 but the changelog incorrectly lists https://github.com/jupyter-server/jupyter_server/releases/tag/v2.15.0 lists 74 (!!) changes

@krassowski krassowski added the bug label Jan 15, 2025
@krassowski
Copy link
Collaborator Author

2.14.0 → 2.15.0 has only 30 PRs so it is even more.

@minrk
Copy link
Contributor

minrk commented Jan 15, 2025

seems like a bug in jupyter-releaser, I suppose

@minrk
Copy link
Contributor

minrk commented Jan 15, 2025

Given that it picked 2.9.1 as the last release, my hunch is that when it auto-picks 'latest' release, it is doing string sorting instead of parsed version sorting since '2.9' > '2.14'

@minrk
Copy link
Contributor

minrk commented Jan 15, 2025

I manually edited the release notes with what I found since 2.14.2. Does it look right now?

@krassowski
Copy link
Collaborator Author

Yes. I think this also needs an update: https://github.com/jupyter-server/jupyter_server/blob/main/CHANGELOG.md#2150

Do you recall if you used the "Use PRs with activity since the last stable git tag" option when running Step 1 of the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants