From 7ac1ae4500b031c181f47817e7ee59d680711fec Mon Sep 17 00:00:00 2001 From: Omar Jarjur Date: Thu, 5 Sep 2024 18:30:11 -0700 Subject: [PATCH] Restore the ability to override the HTTP port a configurable serverapp listens on When invoking the `jp_configurable_serverapp` fixture, there are multiple keyword arguments supported for overriding the values specified by other fixtures. One of those keyword arguments, `http_port`, is never used. I believe this was accidentally broken by https://github.com/jupyter-server/pytest-jupyter/pull/33 where multiple variables named `http_port` referencing a provided fixture were renamed to `jp_http_port`. However, that change also modified one instance of `http_port` that was not a reference to the fixture, but rather a reference to the keyword argument with that same name. This change fixes that by undoing that one line of the change. --- pytest_jupyter/jupyter_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytest_jupyter/jupyter_server.py b/pytest_jupyter/jupyter_server.py index be9bd26..c23c2d7 100644 --- a/pytest_jupyter/jupyter_server.py +++ b/pytest_jupyter/jupyter_server.py @@ -197,7 +197,7 @@ def _configurable_serverapp( app = ServerApp.instance( # Set the log level to debug for testing purposes log_level="DEBUG", - port=jp_http_port, + port=http_port, port_retries=0, open_browser=False, base_url=base_url,