From 595c96cc33074a625e8e9b9eefef2a089cd9ab34 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 07:16:30 +0000 Subject: [PATCH 1/7] Test against Python 3.12 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fcbfb32500..c23807a5ee 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -118,7 +118,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] - python: ['3.8', '3.11'] + python: ['3.8', '3.11', '3.12'] include: - python: '3.8' dist: 'notebook*.tar.gz' From bf2c78ac8d0550d68b63bdd8e83c1d65b44bac22 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 10:07:01 +0200 Subject: [PATCH 2/7] Only on `ubuntu-latest` for now --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c23807a5ee..fc0e60c7f1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -118,7 +118,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] - python: ['3.8', '3.11', '3.12'] + python: ['3.8', '3.11'] include: - python: '3.8' dist: 'notebook*.tar.gz' @@ -130,6 +130,8 @@ jobs: py_cmd: python3 - os: ubuntu-latest py_cmd: python + - os: ubuntu-latest + python-version: "3.12" steps: - name: Install Python uses: actions/setup-python@v4 From d3cc1e7fbc490b098534cc0441ac64f813fc75fb Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 10:17:52 +0200 Subject: [PATCH 3/7] Fix typo --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fc0e60c7f1..981cbfb35a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -131,7 +131,7 @@ jobs: - os: ubuntu-latest py_cmd: python - os: ubuntu-latest - python-version: "3.12" + python: "3.12" steps: - name: Install Python uses: actions/setup-python@v4 From c116dfcc93dc1d1c381c5de96fe8e463b67ea17d Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 10:46:17 +0200 Subject: [PATCH 4/7] `allow-prereleases: true` --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 981cbfb35a..b3390056e9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -138,6 +138,7 @@ jobs: with: python-version: ${{ matrix.python }} architecture: 'x64' + allow-prereleases: true - uses: actions/download-artifact@v3 with: name: notebook-dist-${{ github.run_number }} From 2cc76faab858b2c325cdf540085d18793a185993 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 10:55:29 +0200 Subject: [PATCH 5/7] Fix `py_cmd` --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b3390056e9..31e4116f3f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -131,6 +131,7 @@ jobs: - os: ubuntu-latest py_cmd: python - os: ubuntu-latest + py_cmd: python python: "3.12" steps: - name: Install Python From 829eebb864eaf08a3371d35f2a45febf7000e00d Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 11:09:15 +0200 Subject: [PATCH 6/7] Update build.yml --- .github/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 31e4116f3f..3bddb250e1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -124,6 +124,8 @@ jobs: dist: 'notebook*.tar.gz' - python: '3.11' dist: 'notebook*.whl' + - python: '3.12' + dist: 'notebook*.whl' - os: windows-latest py_cmd: python - os: macos-latest From f6f72f9dc7e8b7e3a357bf897481d8a4c52db1db Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 4 Aug 2023 14:06:10 +0200 Subject: [PATCH 7/7] Try all platforms on 3.12 --- .github/workflows/build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3bddb250e1..0663d839b3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -118,7 +118,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] - python: ['3.8', '3.11'] + python: ['3.8', '3.11', '3.12'] include: - python: '3.8' dist: 'notebook*.tar.gz' @@ -132,9 +132,6 @@ jobs: py_cmd: python3 - os: ubuntu-latest py_cmd: python - - os: ubuntu-latest - py_cmd: python - python: "3.12" steps: - name: Install Python uses: actions/setup-python@v4