From 19c4d4953a1f954a94f19e1d340e9f5873b6295d Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 15:01:01 +0000 Subject: [PATCH 1/6] Set explicit `artifact_name` when uploading coverage data --- .github/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fe53675e48..febf6992c4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -62,6 +62,8 @@ jobs: python -m jupyterlab.browser_check - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1 + with: + artifact_name: coverage-${{ matrix.python }} coverage: runs-on: ubuntu-latest From e84c0c1a2f8fee3d67feecae0252d5e3dcc9f4a6 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 15:03:57 +0000 Subject: [PATCH 2/6] fix typo --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index febf6992c4..d169cd7bbb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -63,7 +63,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1 with: - artifact_name: coverage-${{ matrix.python }} + artifact_name: coverage-${{ matrix.python-version }} coverage: runs-on: ubuntu-latest From 5786d58f428304732f18f44db85bbd545a624f60 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 15:35:27 +0000 Subject: [PATCH 3/6] upload after tests --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d169cd7bbb..1306b1a1b1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -49,6 +49,10 @@ jobs: - name: Test the package run: hatch run cov:test + - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1 + with: + artifact_name: coverage-${{ matrix.python-version }} + - name: JavaScript tests run: | hatch run js_test @@ -61,10 +65,6 @@ jobs: jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" - python -m jupyterlab.browser_check - - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1 - with: - artifact_name: coverage-${{ matrix.python-version }} - coverage: runs-on: ubuntu-latest needs: From e80a492f3a222ff3de75604d173d2d14015f4f63 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 16:00:33 +0000 Subject: [PATCH 4/6] debug --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1306b1a1b1..60b9aaf70d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -49,7 +49,7 @@ jobs: - name: Test the package run: hatch run cov:test - - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1 + - uses: jtpio/maintainer-tools/.github/actions/upload-coverage@include-hidden-files with: artifact_name: coverage-${{ matrix.python-version }} From 34da4fb538c286cb16e888bc42dffbfb5bc178cf Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 16:24:50 +0000 Subject: [PATCH 5/6] dbg --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 60b9aaf70d..a7e9945e74 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -49,7 +49,7 @@ jobs: - name: Test the package run: hatch run cov:test - - uses: jtpio/maintainer-tools/.github/actions/upload-coverage@include-hidden-files + - uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@main with: artifact_name: coverage-${{ matrix.python-version }} @@ -71,7 +71,7 @@ jobs: - test steps: - uses: actions/checkout@v4 - - uses: jupyterlab/maintainer-tools/.github/actions/report-coverage@v1 + - uses: jtpio/maintainer-tools/.github/actions/report-coverage@debug-coverage with: fail_under: 78 From 2f3dc7c55d5b57facc60bfaf6d7c709f9d99d5d5 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 10 Sep 2024 16:37:08 +0000 Subject: [PATCH 6/6] wip --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a7e9945e74..a7ad45c34e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -71,7 +71,7 @@ jobs: - test steps: - uses: actions/checkout@v4 - - uses: jtpio/maintainer-tools/.github/actions/report-coverage@debug-coverage + - uses: jtpio/maintainer-tools/.github/actions/report-coverage@include-hidden-files-2 with: fail_under: 78