Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log messages and --list-images fail to report builds of images without valuesPath #189

Open
consideRatio opened this issue Oct 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@consideRatio
Copy link
Member

As suggested in jupyterhub/zero-to-jupyterhub-k8s#2917 (comment), one could build an image without valuesPath set. It seems we would not report on doing that though, just our updates to the values.yaml file.

Here is some logic that needs to be updated.

chartpress/chartpress.py

Lines 1210 to 1234 in d326521

# build images
values_file_modifications = build_images(
prefix=args.image_prefix or chart.get("imagePrefix", ""),
images=chart["images"],
tag=common_image_tag,
push=args.push,
force_push=args.force_push,
force_build=args.force_build,
skip_build=args.no_build or args.reset,
base_version=base_version,
long=args.long,
builder=args.builder,
platforms=args.platform,
)
# list images
if args.list_images:
seen_images = set()
for key, image_dict in values_file_modifications.items():
image = "{repository}:{tag}".format(**image_dict)
if image not in seen_images:
print(image)
# record image, in case the same image occurs in multiple places
seen_images.add(image)
return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant