Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy 2 compatibility issue with JupyterHub<3.0 #477

Closed
Sheila-nk opened this issue Feb 21, 2023 · 3 comments
Closed

SQLAlchemy 2 compatibility issue with JupyterHub<3.0 #477

Sheila-nk opened this issue Feb 21, 2023 · 3 comments
Labels

Comments

@Sheila-nk
Copy link
Contributor

Bug description

JupyterHub backported the sqalchemy compatibility fix to JupyterHub>=3.0 but didn't restrict the sqlalchemy version to < 2.0 for JupyterHub<3.0. Tests on GitHub Actions are failing due to this. More info: jupyterhub/jupyterhub#4312

sqlalchemy error

Expected behaviour

Tests on GHA should pass or fail without any error messages related to sqlalchemy

Actual behaviour

See bug description

How to reproduce

Making a pull request or a draft pull request triggers GHA to run, exposing the failing tests due to this bug.

Your personal set up

  • OS:
  • Version(s):
Full environment
# paste output of `pip freeze` or `conda list` here
Configuration
# jupyterhub_config.py
Logs
@Sheila-nk Sheila-nk added the bug label Feb 21, 2023
@welcome
Copy link

welcome bot commented Feb 21, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@GeorgianaElena
Copy link
Member

Thanks for opening this issue @Sheila-nk!

My proposal would be to not frame this issue like a bug report, but rather a proposal for discussion on the best solution forward:

Also, this is not a bug necessarily since jupyterhub >= 3 has the compatibility issue fixed.

@Sheila-nk
Copy link
Contributor Author

Closed in favor of #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants