Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstact ChatModel in @jupyter/chat #157

Open
brichet opened this issue Feb 6, 2025 · 0 comments
Open

Abstact ChatModel in @jupyter/chat #157

brichet opened this issue Feb 6, 2025 · 0 comments
Assignees
@brichet

Comments

@brichet
Copy link
Collaborator

brichet commented Feb 6, 2025

I got a bit lost by the inheritance structure while reviewing this. We have IChatModel, then we have ChatModel implementing that interface (defined in @jupyter/chat), and then we have LabChatModel extending ChatModel in jupyterlab-chat.

As a reviewer, I was confused about why the Jupyter Chat project provides two implementations of IChatModel.

It seems like ChatModel in @jupyter/chat should be an abstract base class, and ChatModel should be renamed to AbstractChatModel. This would help make the inheritance structure more obvious. What are your thoughts on this?

Originally posted by @dlqqq in #148 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brichet brichet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brichet