Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible toolbar #170

Open
jtpio opened this issue Feb 15, 2025 · 2 comments
Open

Extensible toolbar #170

jtpio opened this issue Feb 15, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Feb 15, 2025

Problem

Currently it looks like jupyter-chat does not provide the ability to stop message streaming. Or a way to provide streaming functionality from another extension.

Proposed Solution

JupyterAI v2 seems to be supporting this via jupyterlab/jupyter-ai#1022

Image

This would likely require porting some of the work originally done in jupyterlab/jupyter-ai#1022.

Probably jupyter-chat should only focus on providing the "Stop" button, and a way to customize behavior on stop via plugins.

Additional context

Currently Jupyter AI v3 (in dev) does not seem to be supporting that:

Image

@brichet
Copy link
Collaborator

brichet commented Feb 17, 2025

I don't know if we should include the stop button in jupyter-chat, it seems to be only useful when using LLM with streaming.

A more generic way could be to have an extensible toolbar.

@jtpio
Copy link
Member Author

jtpio commented Feb 17, 2025

A more generic way could be to have an extensible toolbar.

Yes, after thinking more about it that would make more sense, and be totally fine to add the button in an extension.

@jtpio jtpio changed the title Add a stop button (to stop message streaming) Extensible toolbar Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants