Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store key seed with secure enclave/keychain #5

Open
jurvis opened this issue Sep 6, 2022 · 0 comments
Open

Store key seed with secure enclave/keychain #5

jurvis opened this issue Sep 6, 2022 · 0 comments

Comments

@jurvis
Copy link
Owner

jurvis commented Sep 6, 2022

KeysManager takes in a 32-byte seed to derive keys. We generate one here but currently persist it trivially by writing it to disk unencrypted.

Instead, we should store it in the Keychain or, even better, the Secure Enclave. We likely will need to support both, for Macs without a touch bar, Touch ID, or Apple Silicon.

@jurvis jurvis added this to the Basic Security Enhancements milestone Sep 6, 2022
@jurvis jurvis changed the title Store key with secure enclave/keychain Store key seed with secure enclave/keychain Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant