Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFRACTOR] Hooks recieve a single parameter #639

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[REFRACTOR] Hooks recieve a single parameter #639

merged 1 commit into from
Jan 23, 2025

Conversation

TungstnBallon
Copy link
Contributor

@TungstnBallon TungstnBallon commented Jan 21, 2025 •
edited
Loading

This PR changes the hook's signature to only receive one object with the previous parameter as properties. This has the following advantages:

  • Backwards compatibility: Adding new "parameters" at whatever position doesn't break existing code
  • It's easier to ignore unused "parameters".

Depends on #638.

@TungstnBallon TungstnBallon self-assigned this Jan 21, 2025
@TungstnBallon TungstnBallon marked this pull request as ready for review January 23, 2025 08:38
@TungstnBallon TungstnBallon requested a review from joluj January 23, 2025 08:38
joluj
joluj approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TungstnBallon TungstnBallon merged commit 186dcb7 into main Jan 23, 2025
3 checks passed
@TungstnBallon TungstnBallon deleted the hooks-3 branch January 23, 2025 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joluj joluj joluj approved these changes

Assignees

@TungstnBallon TungstnBallon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TungstnBallon @joluj