Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentages > 100 for recursive methods #186

Open
PhRX opened this issue Feb 7, 2017 · 1 comment
Open

Percentages > 100 for recursive methods #186

PhRX opened this issue Feb 7, 2017 · 1 comment
Labels

Comments

@PhRX
Copy link
Contributor

PhRX commented Feb 7, 2017

In the "flat" or "list" views of methods, it is possible to see percentages exceeding 100%. This happens when a method recursively calls itself directly or indirectly.

Say that in 110 samples, x.y.A is called 100 times from e.g. x.y.Z, and 50 of those times it calls itself again.

That means that x.y.A, when aggregated, will have a total sample count of 150, but the profile only has 110 samples.

Not sure yet how to deal with this. Maybe detect recursion somehow and use max(sample counts) ? Or just highlight methods which call themselves (in)directly ?

@nitsanw
Copy link
Member

nitsanw commented Feb 19, 2017

A solution would be to shrink a trace into a distinct set of methods before applying the increment to counters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants