Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to know if logic is valid? #122

Open
josephdpurcell opened this issue Jan 22, 2023 · 2 comments · May be fixed by #123
Open

How to know if logic is valid? #122

josephdpurcell opened this issue Jan 22, 2023 · 2 comments · May be fixed by #123

Comments

@josephdpurcell
Copy link

The is_logic function seems to cause some confusion. Here are relevant conversations:

This ticket is to find some way to reduce the confusion around the is_logic function. I think the expectation is that the is_logic function is validating the logic, but the function does not do that. Instead, the function is more answering the question of "is this variable something that should be interpreted as logic, versus some other thing like a primitive type.

At present, there is no robust way to validate that logic is valid, where "valid" means when the logic is executed it will not fail because of syntax or sematic errors. For example, if you execute an if logic with 0 parameters or 4 parameters there is nothing stopping you.

@josephdpurcell josephdpurcell linked a pull request Jan 22, 2023 that will close this issue
@Sykander
Copy link

Sykander commented Feb 8, 2023

Sounds like you need a json-logic-linter,

I have one in my organisation, lemme see if they will open-source it.

@ahmedelq
Copy link

ahmedelq commented Sep 3, 2024

I have one in my organisation, lemme see if they will open-source it.

Did you check if they will open-source it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants