Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GH Issues as discussion system #38

Open
alxsimo opened this issue May 23, 2017 · 3 comments
Open

Use GH Issues as discussion system #38

alxsimo opened this issue May 23, 2017 · 3 comments
Assignees
Milestone

Comments

@alxsimo
Copy link
Collaborator

alxsimo commented May 23, 2017

Maybe can be a good idea to add support for using GH Issues as discussion system instead of Disqus: http://donw.io/post/github-comments/

Very useful for programming or IT blogs.

@jwillmer
Copy link
Owner

I know that blog post and have thought about it myself. This is what the post is saying about Disqus:

  • Long load-time
  • A lot of network requests
  • A lot of non-relevant requests (user tracking)

With the current Disqus implementation we don't have the above problems. We don't start loading comments (Disqus) before someone clicks on view comments. This way loading of the website is fast and people who like to read the comments/add a comment can still do it.

This is how a site load looks with Disqus support enabled (no unnecessary requests!)
loading

That sad, the only reason I can see for replacing Disqus with GH issues (as comments) is because there is currently a hype about the GH comments system and it comes down to personal flavor.

I don't mind to support two comment systems as long as they are easy to setup and to replace. So if someone likes to have GH comments (you?) please feel free to implement it and send me a pull request.

I am closing this issue since I will currently not implement it.

@alxsimo
Copy link
Collaborator Author

alxsimo commented May 24, 2017

Sure! I will do it

@jwillmer
Copy link
Owner

Sorry, I did not recognize that the pull request of the Disqus implementation was actually from you. I guess I did not needed to tell you how it works 🙊

@jwillmer jwillmer added this to the Road to version 1.1.9 milestone Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants